-
Notifications
You must be signed in to change notification settings - Fork 44
Update instruction how to update contraints files #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
```bash | ||
uv pip compile --python-version 3.11 --upgrade --output-file resources/constraints/constraints_py3.11_docs.txt pyproject.toml resources/constraints/version_denylist.txt resources/constraints/version_denylist_examples.txt ../docs/requirements.txt resources/constraints/pydantic_le_2.txt --extra pyqt5 --extra pyqt6 --extra pyside2 --extra pyside6_experimental --extra testing --extra testing_extra --extra optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't resources/constraints/version_denylist_examples.txt
be kept (as in napari/napari#7788 ) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed from docs to normal constraints, as docs are still on python 3.10.
Once we understand the source of problems in #7714 we may get docs constraints here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is now resolved as napari/napari#7714 is merged! Can we add this in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melissawm I think bumping to 3.12 makes sense now that #7714 has landed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works locally now (with my comment), thanks!
|
||
```bash | ||
uv pip compile --python-version 3.11 --upgrade --output-file resources/constraints/constraints_py3.11_docs.txt pyproject.toml resources/constraints/version_denylist.txt resources/constraints/version_denylist_examples.txt ../docs/requirements.txt resources/constraints/pydantic_le_2.txt --extra pyqt5 --extra pyqt6 --extra pyside2 --extra pyside6_experimental --extra testing --extra testing_extra --extra optional | ||
uv pip compile --python-version 3.12 --output-file resources/constraints/constraints_py3.12.txt pyproject.toml resources/constraints/version_denylist.txt --extra pyqt6 --extra pyside2 --extra pyside6_experimental --extra testing --extra testing_extra --extra optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this updates 3.12, we want to update docs though, right? I think this does that
uv pip compile --python-version 3.12 --output-file resources/constraints/constraints_py3.12.txt pyproject.toml resources/constraints/version_denylist.txt --extra pyqt6 --extra pyside2 --extra pyside6_experimental --extra testing --extra testing_extra --extra optional | |
uv pip compile --python-version 3.10 --output-file resources/constraints/constraints_py3.10_docs.txt pyproject.toml resources/constraints/version_denylist.txt --extra pyqt6 --extra pyside2 --extra pyside6_experimental --extra testing --extra testing_extra --extra optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can now use 3.12 here 🎉
@napari-bot make slimgallery |
Team, let's try to land this doc pr this week. |
Co-authored-by: Constantin Aronssohn <[email protected]>
Co-authored-by: Constantin Aronssohn <[email protected]>
@melissawm This worked fine for creating the constraint file for 3.12. Running embedding documentation hyperlinks...
Traceback (most recent call last):
File "/Users/willingc/Code/repos-napari/napari-docs/.venv/lib/python3.12/site-packages/sphinx/events.py", line 98, in emit
results.append(listener.handler(self.app, *args))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/willingc/Code/repos-napari/napari-docs/.venv/lib/python3.12/site-packages/sphinx_gallery/docs_resolv.py", line 502, in embed_code_links
_embed_code_links(app, gallery_conf, gallery_dir)
File "/Users/willingc/Code/repos-napari/napari-docs/.venv/lib/python3.12/site-packages/sphinx_gallery/docs_resolv.py", line 341, in _embed_code_links
doc_resolvers[this_module] = SphinxDocLinkResolver(
^^^^^^^^^^^^^^^^^^^^^^
File "/Users/willingc/Code/repos-napari/napari-docs/.venv/lib/python3.12/site-packages/sphinx_gallery/docs_resolv.py", line 166, in __init__
index = get_data(index_url, gallery_dir)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/willingc/Code/repos-napari/napari-docs/.venv/lib/python3.12/site-packages/sphinx_gallery/docs_resolv.py", line 50, in get_data
search_index = shelve.open(cached_file)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Cellar/[email protected]/3.12.11/Frameworks/Python.framework/Versions/3.12/lib/python3.12/shelve.py", line 243, in open
return DbfilenameShelf(filename, flag, protocol, writeback)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Cellar/[email protected]/3.12.11/Frameworks/Python.framework/Versions/3.12/lib/python3.12/shelve.py", line 227, in __init__
Shelf.__init__(self, dbm.open(filename, flag), protocol, writeback)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Cellar/[email protected]/3.12.11/Frameworks/Python.framework/Versions/3.12/lib/python3.12/dbm/__init__.py", line 89, in open
raise error[0]("db type could not be determined")
dbm.error: db type could not be determined
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/Users/willingc/Code/repos-napari/napari-docs/.venv/lib/python3.12/site-packages/sphinx/cmd/build.py", line 337, in build_main
app.build(args.force_all, args.filenames)
File "/Users/willingc/Code/repos-napari/napari-docs/.venv/lib/python3.12/site-packages/sphinx/application.py", line 380, in build
self.events.emit('build-finished', None)
File "/Users/willingc/Code/repos-napari/napari-docs/.venv/lib/python3.12/site-packages/sphinx/events.py", line 109, in emit
raise ExtensionError(
sphinx.errors.ExtensionError: Handler <function embed_code_links at 0x104129440> for event 'build-finished' threw an exception (exception: db type could not be determined)
Extension error (sphinx_gallery.docs_resolv):
Handler <function embed_code_links at 0x104129440> for event 'build-finished' threw an exception (exception: db type could not be determined)
make: *** [docs] Error 2
napari-docs on update_constraints [$] via v3.12.11 (napari-docs) took 3m26s There were also several Reran after installing optional-numba. Got the spinning ball of doom after hitting the first OMP output on my M1 mac. |
I don't have 3.12 handy right now, but ran in my 3.13 docs env. edit: note: |
napari info:
|
What is currently blocking? |
I think nothing, per se. |
Let's land this. I was able to clean and regenerate. All seems well. |
References and relevant issues
closes #670
napari/napari#7642
napari/napari#7487
Description
After the most recent updates of constraints update, we could simplify this instrucition.